Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdav: 5.7.0 -> 5.7.1 #370950

Merged
merged 2 commits into from
Jan 14, 2025
Merged

webdav: 5.7.0 -> 5.7.1 #370950

merged 2 commits into from
Jan 14, 2025

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Jan 4, 2025

Diff: hacdias/webdav@v5.7.0...v5.7.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review January 4, 2025 19:27
@nix-owners nix-owners bot requested a review from pmeiyu January 4, 2025 19:37
@pbsbot
Copy link

pbsbot commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370950


x86_64-linux

✅ 1 package built:
  • webdav

@@ -2,13 +2,13 @@

buildGo123Module rec {
pname = "webdav";
version = "5.7.0";
version = "5.7.1";

src = fetchFromGitHub {
owner = "hacdias";
repo = "webdav";
rev = "v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev -> tag

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370950


x86_64-linux

✅ 1 package built:
  • webdav

@pbsds pbsds merged commit 226991c into NixOS:master Jan 14, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants